Skip to content

[Merged] Browser support: Add Yandex.Browser to the list#106

Closed
markelog wants to merge 2 commits intojquery:jquery-3from
markelog:jquery-yabrowser
Closed

[Merged] Browser support: Add Yandex.Browser to the list#106
markelog wants to merge 2 commits intojquery:jquery-3from
markelog:jquery-yabrowser

Conversation

@markelog
Copy link
Member

No description provided.

@mgol
Copy link
Member

mgol commented Jul 17, 2015

This was fixed in 2260fc5, although the commit will be rebased on top of master until jQuery 3.0.0 is released. @markelog did you want to wait until that happens?

@arthurvr what's the strategy you use for other content sites, like https://github.com/jquery/api.jquery.com/?

@markelog
Copy link
Member Author

This was fixed in 2260fc5, although the commit will be rebased on top of master until jQuery 3.0.0 is released.

Yeah, exactly, commit hashes are not the same, because i added Closes ... comment, but they are the same, this pull will autoclose when that commit will be merged to master.

@arthurvr
Copy link
Member

@arthurvr what's the strategy you use for other content sites, like https://github.com/jquery/api.jquery.com/?

We just close the PRs when we land them to the v3 branch, if that's where you're asking for.

@mgol
Copy link
Member

mgol commented Jul 22, 2015

When I merge a PR to the jquery-3 branch it gets auto-closed anyway, see e.g. #107. If we didn't want to get them closed, we'd have to be sure to always cherry-pick, even if a commit can be merged because it's already rebased.

Losing reference to the final version of the commit is not very nice, though. :/

@mgol mgol changed the title Browser support: Add Yandex.Browser to the list [Merged] Browser support: Add Yandex.Browser to the list Nov 2, 2015
markelog added a commit that referenced this pull request Dec 14, 2015
markelog added a commit that referenced this pull request Dec 28, 2015
mgol pushed a commit that referenced this pull request Jan 13, 2016
mgol pushed a commit that referenced this pull request Feb 10, 2016
mgol pushed a commit that referenced this pull request Mar 9, 2016
mgol pushed a commit that referenced this pull request Mar 30, 2016
mgol pushed a commit that referenced this pull request Mar 30, 2016
mgol pushed a commit that referenced this pull request Mar 31, 2016
mgol pushed a commit that referenced this pull request Apr 25, 2016
mgol pushed a commit that referenced this pull request May 9, 2016
mgol pushed a commit that referenced this pull request May 20, 2016
mgol pushed a commit that referenced this pull request May 21, 2016
@timmywil timmywil closed this in b66eaba Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants